New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CBRD-25664] Excluded -1 from the valid range of the page_flush_interval system parameter #5638

Open

InChiJun wants to merge 1 commit into CUBRID:develop from InChiJun:CBRD-25664

InChiJun commented Nov 25, 2024 •

edited

Loading

http://jira.cubrid.org/browse/CBRD-25664

Purpose
- page_flush_interval 시스템 파라미터는 pgbuf_Page_flush_daemon 데몬의 looper를 설정하고 있음
- page_flush_interval 값의 설정 범위는 -1 ~ 1000이며, -1로 설정하면 assert가 발생하고 있음
  - cub_server: /home/hornetmj/work/cubrid/src/storage/page_buffer.c:15713: void pgbuf_get_page_flush_interval(bool&, cubthread::delta_time&): Assertion page_flush_interval_msecs >= 0' failed.`
- 현재 page_flush_interval 값을 0 이하로 설정하면 pgbuf_Page_flush_daemon이 다른 쓰레드가 깨워줄 때까지 무한 대기하도록 구현되어 있음
- 따라서, page_flush_interval 값을 -1 또는 0으로 설정하는 것은 동일한 결과를 얻으며, -1을 설정 범위에 포함할 필요가 없음
Implementation
- page_flush_interval 시스템 파라미터의 설정 범위에서 -1을 제외
Remarks
- N/A


          [CBRD-25664] Excluded: -1 from the valid range of

ee925c4

InChiJun requested review from hornetmj, H2SU and YeunjunLee

November 25, 2024 01:45

InChiJun self-assigned this

InChiJun requested a review from beyondykk9 as a code owner

November 25, 2024 01:45

hornetmj approved these changes

View reviewed changes

H2SU approved these changes

View reviewed changes

YeunjunLee approved these changes

View reviewed changes

beyondykk9 approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet